Add new fields and getter steps for static routing resource timing #1769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is still a draft PR for the resource timing changes. Let me make it open to get the previews |
|
@domenic @yoshisatoyanagisawa @sisidovski Could you take a look and see if this change makes sense? Thanks! |
|
The direction looks good to me. I left some comments on the step order and a data structure for queueing. |
|
Let me update the doc a bit more |
|
I think the PR is ready to be reviewed again. PTAL. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new fields for the static routing API and the getter steps. This will be later exposed to the resource timing API.
Preview | Diff