[css-forms-1] Remove ::slider-track from layout rule #11984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewarlow
force-pushed
the
fix-double-borders
branch
from
f97ba94 to
b48a5a4
Compare
lukewarlow
changed the title
|
cc @nt1m does this seem reasonable to merge? Or should I try and get a discussion in the group for which approach is best? Seems like a bug fix personally? |
|
It kind of depends on which way to go, if you want the more traditional slider style with the track smaller than the thumb, then maybe it makes more sense to remove the border from the host element rather the track. Either way we go I'm fine accepting it as a bug fix in the short term, but it would be good to discuss that bigger decision in the WG. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11841
The alternative considered was to remove progress, meter and add
[type=checkbox][switch]to the input:not selector. I think it makes more sense for the border to be on the host element though (both from an easy of styling perspective and from a layout perspective).