Skip to content

Issue #181 - Redefine network request in terms of Fetch #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 5, 2025

Conversation

miketaylr
Copy link
Member

@miketaylr miketaylr commented Feb 6, 2025

This is Part 1 of N commits to address #166.

It largely just links to existing Fetch concepts.


Preview | Diff

@miketaylr miketaylr marked this pull request as ready for review February 7, 2025 22:55
@miketaylr miketaylr requested a review from clelland February 7, 2025 22:56
@miketaylr
Copy link
Member Author

PTAL @clelland

@miketaylr
Copy link
Member Author

I want to call out #182 (comment) - I thought I left a comment, but I can't find it in the GitHub UI:

I think you're suggesting that HTTP-network fetch handles both of 1) not doing a "network request" from the cache, and 2) not referencing redirects explicitly, because HTTP-network fetch handles that, and prevents serving a redirect response from cache (thus, resulting in a "network request"). Is that correct? Or did I miss the point?

@miketaylr
Copy link
Member Author

Couldn't find "HTTP-network fetch"

Guess it's not exported yet. 🤷

@miketaylr miketaylr requested a review from clelland February 17, 2025 19:02
Copy link
Contributor

@clelland clelland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - one comment about some deleted text that could be useful as a note

@w3c w3c deleted a comment from 8722596300261825028 May 1, 2025
@miketaylr miketaylr merged commit 5e200d5 into w3c:gh-pages May 5, 2025
2 checks passed
@miketaylr miketaylr deleted the issues/181/1 branch May 5, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants