Skip to content

Export named parameters for "generate and queue a report" #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025

Conversation

yoavweiss
Copy link
Contributor

@yoavweiss yoavweiss commented May 15, 2025

The lack of named parameters export came up as part of the review of w3c/webappsec-subresource-integrity#133
This PR adds them.

It also fixes linking errors around Document for both reporting and network reporting.

@yoavweiss yoavweiss requested a review from mikewest May 15, 2025 06:25
Copy link
Contributor

@clelland clelland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! (I don't know how these went unexported for so long)

@yoavweiss yoavweiss merged commit b8418ea into main May 15, 2025
3 checks passed
github-actions bot added a commit that referenced this pull request May 15, 2025
SHA: b8418ea
Reason: push, by yoavweiss

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 15, 2025
SHA: b8418ea
Reason: push, by yoavweiss

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants