Review fixes for #44. #46
Conversation
|
Thanks, see commit 3 in this PR. |
| @@ -1790,19 +1793,19 @@ | |||
| When an <a>NFC device</a> comes in communication range, | |||
| <ul> | |||
| <li> | |||
| If <var>options.target</var> has the value <code>"tag"</code>, | |||
| If <var>target</var> has the value <code>"tag"</code>, | |||
There was a problem hiding this comment.
If the options object's target member has the value "tag",
There was a problem hiding this comment.
Good catch. I stand corrected. The algo is rather long to parse on a small screen.
|
Thanks for the PR, I added some inline comments. |
|
Thanks Anssi, I will fix them in later commits, don't merge until fixed. By now I will have to include them with other changes. |
…itions, algorithms, terminology
zolkis
changed the title
| @@ -1418,6 +1461,9 @@ | |||
| </ul> | |||
| </li> | |||
| <li> | |||
| Let <var>options</var> be the second argument. | |||
There was a problem hiding this comment.
You don't need this, since you've introduced it with pushMessage(message, options) above.
There was a problem hiding this comment.
The more verbose style is consistent with e.g. the HTML spec. I suggest we prefer clarity over brevity. But I don't feel strongly, so leaving it to the editors.
…ations; clear buffer and reset timer on termination.
…pdated task source. Updated page visibility related steps. Editorials.
|
@jyasskin The editors believe your feedback has now been addressed. Could you please review this PR, and let @zolkis and @kenchris know if you'd like the editors to do further changes before merging. This version of the spec does not need to be perfect, but it should be a good base for the next iteration of the experimental implementation. For convenience, here's the RawGit HTML preview of the head of this PR. Thank you again for your extensive and detailed feedback. |
|
Since GH has issues showing the changes, you can use the HTML diff to ease the review. |
|
Will merge this PR now and suggest the editors address the remaining feedback in another PR. |
Fixing comments for #44.