spec: Throw a TypeError if all fields are missing. #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sharing the empty dictionary, or a dictionary with only unrecognised fields, a programmer error, and is designed to aid in future extensions (since if new fields are added, it will be a TypeError to exclusively use them without feature detection). Closes w3c#48.
|
@sammc ptal. Web platform tests updated here: web-platform-tests/wpt@master...mgiuca:web-share-errors-and-arguments |
sammc
approved these changes
Jul 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sharing the empty dictionary, or a dictionary with only unrecognised fields, a programmer error, and is designed to aid in future extensions (since if new fields are added, it will be a TypeError to exclusively use them without feature detection).
Also adds an appendix discussing extending the spec in the future.
Closes #48.
Preview | Diff