-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: suppress excessive console logs after updating to v2.10.1 #4182
fix: suppress excessive console logs after updating to v2.10.1 #4182
Conversation
WalkthroughThe pull request updates the Changes
Sequence Diagram(s)sequenceDiagram
participant A as CreateApp
participant O as appoptions.LogLevel
participant F as Command-line Flag
participant L as Logger
A->>O: Retrieve LogLevel value
A->>L: Validate LogLevel (pkglogger.StringToLogLevel)
alt Validation fails
L-->>A: Return error
A-->>Caller: Exit with error
else Validation succeeds
A->>F: Check for flag-based log level
alt Flag is set
A->>L: Assign flag log level
else
A->>L: Use appoptions.LogLevel
end
end
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🧰 Additional context used🧬 Code Definitions (1)v2/internal/app/app_dev.go (1)
🔇 Additional comments (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Thanks for this! 🙏 |
Description
This PR fixes excessive console logging after updating to Wails v2.10.1 Previously, any Go backend function call results were automatically printed to the console, making it difficult to read actual logs. This update suppresses those unnecessary logs unless explicitly enabled.
Fixes #4111.
Type of change
How Has This Been Tested?
This fix has been tested on the following platforms:
Test Configuration:
Steps to reproduce and verify the fix:
wails dev
on Wails v2.10.1wails dev -loglevel Info
.Checklist
website/src/pages/changelog.mdx
with details of this PR.Summary by CodeRabbit
These updates improve the application's logging behavior, resulting in a cleaner console output and more consistent error reporting.