Upgrade libm and make no-std config testable #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Anderson <[email protected]>
`vec![0; len]` uses a specialized intrinsic codepath, which, at least in debug mode, is extremely faster than `resize`. This makes the `alloc` test pass instantaneously instead of taking minutes. Signed-off-by: Brian Anderson <[email protected]>
Signed-off-by: Brian Anderson <[email protected]>
These no longer exist in the latest revision of libm. Signed-off-by: Brian Anderson <[email protected]>
Fixes wasmi-labs#240 Signed-off-by: Brian Anderson <[email protected]>
Signed-off-by: Brian Anderson <[email protected]>
Signed-off-by: Brian Anderson <[email protected]>
Signed-off-by: Brian Anderson <[email protected]>
|
Thanks!
Unfortunately, FWIW, I've never bumped into this bug. Still I am up for merging this, so hopefully this issue is resolved. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just looking for something to hack on I found #240 and decided to give it a try.
Along they way I needed to address a few other things, so they are all included here:
--no-default-features --features=coreconfiguration testable. This mostly involves manually importing std into test modules.I can't verify that the libm panicking bug is actually fixed since it doesn't seem to be triggered by the test suite.