Skip to content

getTypeScriptCode() can generate for Angular using $http #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 69 commits into
base: master
Choose a base branch
from

Conversation

nalbion
Copy link
Contributor

@nalbion nalbion commented Apr 27, 2016

No description provided.

Nicholas Albion added 4 commits April 27, 2016 12:53
…ed. Use the standard then method instead. If $httpProvider.useLegacyPromiseExtensions is set to false then these methods will throw $http/legacy error.
@wcandillon
Copy link
Owner

@nalbion Would you like to split this PR into smaller PRs? For instance, the externalDocs option seems orthogonal. Also an example on how to use this option would be useful.

Regarding the angular typescript generation, I would make it a complete separate generator instead of being an option to be consistent with the other generators.

@nalbion
Copy link
Contributor Author

nalbion commented Apr 27, 2016

@wcandillon would it make sense to add some extra fields to the options object?

  • language - [javascript], typescript, es2015, flow, (es2015+flow?)...
  • framework - node, superagent (default for typescript?), angular, polymer, reactive...

...might make it easier to create & select generators, language+'-'+framework+'-class.mustache' etc - you could even try to require(language+'-'+framework+'-generator') (and fall-back to the default impl if undefined).

@wcandillon
Copy link
Owner

@nalbion Yes maybe it is time to make things more modular now.

@nalbion
Copy link
Contributor Author

nalbion commented Apr 27, 2016

#125 should help to ensure the output is consistent (or improved)

@nalbion
Copy link
Contributor Author

nalbion commented May 4, 2016

@wcandillon - I've added language and framework fields to opts, and split my template changes into their own files

@nalbion nalbion mentioned this pull request May 4, 2016
@amcdnl
Copy link

amcdnl commented Jun 20, 2016

any updates on this?

@Abrissirba
Copy link

I guess this will not happen since it is over a year ago but I'm interested to know if there any other way to get the response type?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants