Skip to content

Change type of user-defined view_properties in the Query Agent #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CShorten
Copy link
Member

This changes the type of view_properties from list[str] to dict[str, list[str]].

Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@@ -52,7 +52,7 @@ def __init__(
def run(
self,
query: str,
view_properties: Optional[List[str]] = None,
view_properties: Optional[dict[str, list[str]]] = None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this needs to be compatible with the weaviate-client we have to adhere to the older from typing ... typing structure so can we make Optional[dict[str, list[str]]] -> Optional[Dict[str, List[str]]]

Copy link
Collaborator

@cdpierse cdpierse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also bump the version in pyproject.yaml up too with a patch update, let's make sure to rebase from main first to make sure you have the latest version as this will be used to make the release

@cdpierse cdpierse requested a review from augustas1 March 26, 2025 15:47
@CShorten CShorten marked this pull request as ready for review March 27, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants