Skip to content

refactor: remove @babel/plugin-proposal-function-bind #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 26, 2022
Merged

refactor: remove @babel/plugin-proposal-function-bind #1957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d05f21d
refactor: remove @babel/plugin-proposal-function-bind
chenjiahan Oct 26, 2022
2bd654e
Merge branch 'next' into remove_function_bind_plugin_1026
chenjiahan Oct 26, 2022
aebf0b6
chore: fix snapshot
chenjiahan Oct 26, 2022
93440b1
Merge branch 'remove_function_bind_plugin_1026' of https://github.com…
chenjiahan Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/bright-brooms-give.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@modern-js/babel-preset-base': patch
---

refactor: remove @babel/plugin-proposal-function-bind

refactor: 移除 @babel/plugin-proposal-function-bind
30 changes: 0 additions & 30 deletions packages/builder/builder-webpack-provider/tests/plugins/__snapshots__/babel.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,6 @@ exports[`plugins/babel > should add rule to compile Data URI when enable source.
"version": "7.18.6",
},
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-function-bind/index.js",
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-export-default-from/index.js",
],
Expand Down Expand Up @@ -205,9 +202,6 @@ exports[`plugins/babel > should add rule to compile Data URI when enable source.
"version": "7.18.6",
},
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-function-bind/index.js",
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-export-default-from/index.js",
],
Expand Down Expand Up @@ -348,9 +342,6 @@ exports[`plugins/babel > should adjust browserslist when target is node 1`] = `
"version": "7.18.6",
},
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-function-bind/index.js",
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-export-default-from/index.js",
],
Expand Down Expand Up @@ -472,9 +463,6 @@ exports[`plugins/babel > should adjust browserslist when target is node 1`] = `
"version": "7.18.6",
},
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-function-bind/index.js",
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-export-default-from/index.js",
],
Expand Down Expand Up @@ -618,9 +606,6 @@ exports[`plugins/babel > should override targets of babel-preset-env when using
"version": "7.18.6",
},
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-function-bind/index.js",
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-export-default-from/index.js",
],
Expand Down Expand Up @@ -745,9 +730,6 @@ exports[`plugins/babel > should override targets of babel-preset-env when using
"version": "7.18.6",
},
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-function-bind/index.js",
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-export-default-from/index.js",
],
Expand Down Expand Up @@ -886,9 +868,6 @@ exports[`plugins/babel > should set babel-loader 1`] = `
"version": "7.18.6",
},
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-function-bind/index.js",
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-export-default-from/index.js",
],
Expand Down Expand Up @@ -1015,9 +994,6 @@ exports[`plugins/babel > should set babel-loader 1`] = `
"version": "7.18.6",
},
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-function-bind/index.js",
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-export-default-from/index.js",
],
Expand Down Expand Up @@ -1162,9 +1138,6 @@ exports[`plugins/babel > should set include/exclude 1`] = `
"version": "7.18.6",
},
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-function-bind/index.js",
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-export-default-from/index.js",
],
Expand Down Expand Up @@ -1291,9 +1264,6 @@ exports[`plugins/babel > should set include/exclude 1`] = `
"version": "7.18.6",
},
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-function-bind/index.js",
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-export-default-from/index.js",
],
Expand Down
6 changes: 0 additions & 6 deletions packages/builder/builder-webpack-provider/tests/plugins/__snapshots__/react.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,6 @@ exports[`plugins/react > should work with babel-loader 1`] = `
"version": "7.18.6",
},
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-function-bind/index.js",
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-export-default-from/index.js",
],
Expand Down Expand Up @@ -202,9 +199,6 @@ exports[`plugins/react > should work with babel-loader 1`] = `
"version": "7.18.6",
},
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-function-bind/index.js",
],
[
"<ROOT>/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-export-default-from/index.js",
],
Expand Down
1 change: 0 additions & 1 deletion packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-function-bind/index.d.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-function-bind/index.js
View file
Open in desktop

This file was deleted.

22 changes: 0 additions & 22 deletions packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-function-bind/license
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-function-bind/package.json
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions packages/cli/babel-preset-base/src/plugins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,6 @@ export const getPluginsChain = (option: IBaseBabelConfigOption) => {
);
}

chain
.plugin('@babel/plugin-proposal-function-bind')
.use(require.resolve('../compiled/@babel/plugin-proposal-function-bind'));

// link: https://github.com/tc39/proposal-export-default-from
chain
.plugin('@babel/plugin-proposal-export-default-from')
Expand Down
3 changes: 0 additions & 3 deletions packages/cli/webpack/tests/__snapshots__/utils.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@ Object {
"version": "7.18.6",
},
],
Array [
/cli/babel-preset-base/compiled/@babel/plugin-proposal-function-bind/index.js,
],
Array [
/cli/babel-preset-base/compiled/@babel/plugin-proposal-export-default-from/index.js,
],
Expand Down
3 changes: 0 additions & 3 deletions packages/server/utils/tests/__snapshots__/babel.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,6 @@ Object {
"removeImport": true,
},
],
Array [
"/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-function-bind/index.js",
],
Array [
"/packages/cli/babel-preset-base/compiled/@babel/plugin-proposal-export-default-from/index.js",
],
Expand Down
23 changes: 0 additions & 23 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion scripts/prebundle/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
"@babel/parser": "7.18.4",
"@babel/plugin-proposal-decorators": "7.18.2",
"@babel/plugin-proposal-export-default-from": "7.17.12",
"@babel/plugin-proposal-function-bind": "7.16.7",
"@babel/plugin-proposal-partial-application": "7.17.12",
"@babel/plugin-proposal-pipeline-operator": "7.18.2",
"@babel/template": "7.16.7",
Expand Down
7 changes: 0 additions & 7 deletions scripts/prebundle/src/constant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,13 +767,6 @@ export const TASKS: TaskConfig[] = [
'@babel/helper-plugin-utils': '../helper-plugin-utils',
},
},
{
name: '@babel/plugin-proposal-function-bind',
ignoreDts: true,
externals: {
'@babel/helper-plugin-utils': '../helper-plugin-utils',
},
},
{
name: '@babel/helper-create-class-features-plugin',
ignoreDts: true,
Expand Down