Skip to content

Add Riot.js #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 18, 2019
Merged

Add Riot.js #596

merged 5 commits into from
Sep 18, 2019

Conversation

GianlucaGuarini
Copy link
Contributor

I have added Riot.js to the party. Riot.js passes also the tests that were commented out on the other frameworks. Please let me know if I need to comment them out as well.

Thank you

Screenshot 2019-08-31 at 11 01 54

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@GianlucaGuarini
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@GianlucaGuarini
Copy link
Contributor Author

The CI fails for settings that are not related to this PR. Can I help you on that somehow?

@robdodson
Copy link
Contributor

Hey @GianlucaGuarini, I'll try to take a look this week. Thanks for putting this together :)

@justinbmeyer—per our conversation in #580, I was curious if you or a member of your team might have time to also do a review of the tests?

@justinbmeyer
Copy link

I’ll talk to folks Monday.

Co-Authored-By: Rob Dodson <robdodson@users.noreply.github.com>
@GianlucaGuarini
Copy link
Contributor Author

@robdodson please let me know if I could do anything else to help you guys. Side Note: Riot.js could output custom components as well https://github.com/riot/custom-elements

@robdodson
Copy link
Contributor

@GianlucaGuarini I noticed it's showing 26 basic and 14 advanced tests passed. But I think we only have 16 basic tests (that's what the other libraries show).

@GianlucaGuarini
Copy link
Contributor Author

@robdodson that's what I meant with:

Riot.js passes also the tests that were commented out on the other frameworks

Should I re-comment them out even if Riot.js could handle more unit tests without problems?

@robdodson
Copy link
Contributor

oh! yes please comment them out. thank you!

@GianlucaGuarini
Copy link
Contributor Author

@robdodson I have commented out the Riot.js tests, I think this decision might bias a bit the final results but at least it's consistent with the other frameworks.

@robdodson robdodson merged commit 56878f6 into webcomponents:master Sep 18, 2019
@robdodson
Copy link
Contributor

Rad thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants