-
Notifications
You must be signed in to change notification settings - Fork 16
Working example of the chat using quic,protobuf and actix #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
r-zig
wants to merge
44
commits into
whamcloud:main
Choose a base branch
from
r-zig:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…client logic. Includes: - `server` and `client` libraries - `server-cli` and `client-cli` binaries Each CLI depends on its corresponding library. This is the base skeleton for future development.
…ith missing decode_length_delimited
remove common remove certificates change default server listening address to ipv4 localhost instead of ipv6 send messages with encoded length receiver stream handling with typed ProtobufStreamError and recoverable approach
…on lost in the server
Signed-off-by: r-zig <[email protected]>
Signed-off-by: r-zig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the simple chat application as per your request.
You can view a demo video of the working solution here:
Example Server and Clients
I chose to use QUIC for transport and Protobuf for encoding. During this process, I also created a separate crate for handling Protobuf streams, which provides a mechanism to recover when incoming data is out of sync. The messages are encoded with a length delimiter. You can find the crate here:
Protobuf Stream
The server is implemented using Actix to ensure optimal performance and minimal contention.
The GitHub Actions workflow successfully runs the tests. However, I encountered an issue with the client that only occurs in the CI environment. Since I was unable to resolve this problem in time, I decided to submit the PR as is to avoid further delays.