Skip to content
This repository was archived by the owner on Mar 16, 2019. It is now read-only.

Deprecated createJSModules on Android only for RN >= 0.47 #522

Open
wants to merge 5 commits into
base: 0.10.9
Choose a base branch
from
Open

Deprecated createJSModules on Android only for RN >= 0.47 #522

wants to merge 5 commits into from

Conversation

jkomyno
Copy link

@jkomyno jkomyno commented Sep 15, 2017

[BUG FIX]

createJSModules is now not required on Android from RN 0.47. This is backwards compatible according to my tests.

@lll000111
Copy link
Contributor

lll000111 commented Sep 17, 2017

So the PR is just for

 // Deprecated RN 0.47

?

I recommend you always provide a source (URL) for things like that. Somebody reading the code would (should!) like to know where such a piece of information comes from, to look at the details.

It would also be nice to know what this means. Not having looked at the details (for which that URL would be helpful, I don't follow RN development closely), it seems to me this is just "okay, good to know", no action required(?).

@jkomyno
Copy link
Author

jkomyno commented Sep 19, 2017

I'm sorry, I forgot to add the link below in this first PR message.
This is the react-native commit that caused this PR: facebook/react-native@ce6fb33

@jkomyno
Copy link
Author

jkomyno commented Sep 19, 2017

For reference, you can also take a look here:
wix-incubator/react-native-interactable#131

@lll000111
Copy link
Contributor

FYI

react-native-fetch-blob has a new maintained location. Check out the README.

Please consider submitting your PR there, this repository is unmaintained.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants