Prevent overwriting default with a translation #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can also be fixed by my proposed change to react-t |
|
formatting fixed, sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi :)
In some cases, the default (en-US) language version is being overwritten by a translation - instead of setting the language to user's language in the Options dropdown, the 'English (US) version is being replaced with the user's language.
Here's a screenshot of how that situation looked for me:
This situation seems to not be desired, as now the English translation is not accessible - in the case from the screenshot, both English and Polish options show a Polish translation, with no way to show the English version. This can easily lead to the user not being able to access a version of the site understandable to them, if the user's preferred language has not been recognized correctly.
In my particular case:
In my case the site was exhibiting the behavior described above - English version was replaced with Polish, with no way to access the English version.
Removing Polish from the list of my languages in firefox made the site show up correctly in English.
This pull request fixes the issue by adding an English language file. With this fix, in my case, the English language option is no longer being overwritten.
In case where the translation is actually needed (it is set in locale) already existing code changes the value of the language selection to user locale.
There is a very similar pull request open (#188), which has not been merged, i assume due to not explaining why it is needed.