Skip to content

Update Shipping entity to include contact fields (email, phone) (4808) #3463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

stracker-phil
Copy link
Collaborator

This PR extends #3457

Description

Extend the Shipping class to contain the two optional properties email_address and phone_number

Those properties are populated from the API's response object purchase_units[].shipping, so they depend on the presence of the shipping address in the order data

@stracker-phil stracker-phil changed the base branch from trunk to PCP-4805-write-tests-for-payload-structure June 17, 2025 13:56
Copy link
Collaborator

@Narek13 Narek13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

Copy link
Collaborator

@danieldudzic danieldudzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward!

Base automatically changed from PCP-4805-write-tests-for-payload-structure to trunk June 23, 2025 09:02
@Dinamiko Dinamiko merged commit ace3ac2 into trunk Jun 23, 2025
7 checks passed
@Dinamiko Dinamiko deleted the PCP-4808-update-shipping-entity-to-include-contact-fields-email-phone branch June 23, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants