-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: GutenbergKit internationalization #21854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dcalhoun
wants to merge
7
commits into
trunk
Choose a base branch
from
feat/gutenberg-kit-internationalization
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Project dependencies changeslist! Upgraded Dependencies
org.wordpress.gutenbergkit:android:120-e83c5f9a1f841e9ebc61f7135e16e45372240a10, (changed from v0.2.0) tree +--- project :libs:editor
-| \--- org.wordpress.gutenbergkit:android:v0.2.0
+| \--- org.wordpress.gutenbergkit:android:120-e83c5f9a1f841e9ebc61f7135e16e45372240a10
-\--- org.wordpress.gutenbergkit:android:v0.2.0 (*)
+\--- org.wordpress.gutenbergkit:android:120-e83c5f9a1f841e9ebc61f7135e16e45372240a10 (*) |
1a79551
to
b238c9e
Compare
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21854-eeb28f7 | |
Commit | eeb28f7 | |
Direct Download | jetpack-prototype-build-pr21854-eeb28f7.apk |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21854-eeb28f7 | |
Commit | eeb28f7 | |
Direct Download | wordpress-prototype-build-pr21854-eeb28f7.apk |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #21854 +/- ##
=======================================
Coverage 39.38% 39.38%
=======================================
Files 2134 2134
Lines 100053 100053
Branches 15408 15408
=======================================
Hits 39406 39406
Misses 57164 57164
Partials 3483 3483 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a833661
to
8ba3847
Compare
Enable localization within the editor.
8ba3847
to
0f73c3c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref CMM-280. Provide GutenbergKit with the current locale so that localization may occur.
Testing instructions
See wordpress-mobile/GutenbergKit#120.