Add custom_attributes field to SSO Profile #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgd
commented
Apr 17, 2025
| profile=None, | ||
| role=None, |
There was a problem hiding this comment.
This was incorrect in fixture, just fixing.
mattgd
commented
Apr 23, 2025
| @@ -23,7 +23,8 @@ class Profile(WorkOSModel): | |||
| idp_id: str | |||
| role: Optional[ProfileRole] = None | |||
| groups: Optional[Sequence[str]] = None | |||
| raw_attributes: Mapping[str, Any] | |||
| custom_attributes: Optional[Mapping[str, Any]] = None | |||
There was a problem hiding this comment.
I'd like to add a generic type for custom_attributes that developers can override, but ran into some mypy limitations with default values for generic types. Keeping this as-is for now.
…tributes-to-python-sdk
gcarvelli
approved these changes
Apr 23, 2025
…tributes-to-python-sdk
mattgd
deleted the
feature/dsync-2978-add-sso-profile-custom_attributes-to-python-sdk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
custom_attributesfield to SSO Profile.Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.