feat: dockerize #2379
Open
feat: dockerize #2379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Thoughtscript this is pretty cool. I especially like how you've reused the make script. |
plaindocs
reviewed
Jun 5, 2025
| @@ -59,6 +59,9 @@ html: | |||
| livehtml: | |||
| sphinx-autobuild --port 8888 -j auto --watch _data -b dirhtml $(ALLSPHINXOPTS) $(BUILDDIR)/html | |||
|
|
|||
| dockerhtml: | |||
There was a problem hiding this comment.
Worth commenting here that this is for use inside the Docker image, not externally to run it?
| @@ -18,6 +18,7 @@ if "%1" == "help" ( | |||
| echo.Please use `make ^<target^>` where ^<target^> is one of | |||
| echo. html to make standalone HTML files | |||
| echo. livehtml to make live HTML files to view the docs on a local web server | |||
| echo. dockerhtml to make live HTML files and view through a local docker container | |||
There was a problem hiding this comment.
Definitely worth clarifying here.
Comment on lines
+1
to
+5
| #!/usr/bin/env bash | ||
|
|
||
| cd docs && make dockerhtml & | ||
|
|
||
| wait |
There was a problem hiding this comment.
Don't suppose we can fold this inside the Dockerfile and drop the file?
Comment on lines
+116
to
+120
| 1. Build the Docker Image from the root directory with the command: `docker build .` | ||
| 1. Find the created Docker Image ID: `docker images` - something like: `sha256:123...` | ||
| 1. Run the Docker Image Container using that Image ID: `docker run -p 8888:8888 sha256:123...` | ||
| 1. Access the live site on <http://localhost:8888> through your web browser | ||
| 1. Both the Docker Container and Image will be present in Docker Desktop |
There was a problem hiding this comment.
Would it make sense to tag the dockerfile as wtd on creation, and then run the tag? Probably not, you still need the image sha.
Is there no way to just say "run the image build from the current dir" without going around looking for the ID?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I went ahead and Dockerized the source code to make it easier to get setup locally (it'd probably need quite a bit more to be used in Production/Production-worthy).
Checklist:
makecommand specific to Docker - binds to0.0.0.0locally to expose through Docker.dockerfileand testing.Browser:
Docker:
📚 Documentation preview 📚: https://writethedocs-www--2379.org.readthedocs.build/