Skip to content

Adding supported image formats in sm-list #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gthvn1
Copy link

@gthvn1 gthvn1 commented Apr 2, 2025

When running xe sm-list params=all you will now have the info of supported image formats if the SM plugin specified it in its DRIVER_INFO. The field is called supported-image-formats. If the plugin doesn't provide the info the field will be empty.

@gthvn1 gthvn1 force-pushed the gtn-supported-image-formats branch from 8c2faa4 to 2ed7439 Compare April 2, 2025 11:49
@coveralls
Copy link

coveralls commented Apr 2, 2025

Pull Request Test Coverage Report for Build 14227355106

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.719%

Totals Coverage Status
Change from base Build 14227043489: 0.0%
Covered Lines: 3359
Relevant Lines: 4322

💛 - Coveralls

When running `xe sm-list params=all` you will now have the info of
supported image formats if the SM plugin specified it in its DRIVER_INFO.
The field is called `supported-image-formats`. If the plugin doesn't
provide the info the field will be empty.

Signed-off-by: Guillaume <[email protected]>
@gthvn1 gthvn1 force-pushed the gtn-supported-image-formats branch from 2ed7439 to 177f8c5 Compare April 2, 2025 18:55
@gthvn1
Copy link
Author

gthvn1 commented May 21, 2025

superseded by #10
As it is not trivial to backport the patch we start by developed it on our 8.3 version, test it and if everything works as expected then proposed it upstream. Pushing it upstream now will need to maintain two branches with one that cannot be tested. So we prefer to focus on test knowing the design as been pushed upstream.

@gthvn1 gthvn1 closed this May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants