Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmake): Bump yaml-cpp and ANTLR4 versions to resolve CMake deprecation errror. #794

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Bill-hbrhbr
Copy link
Contributor

@Bill-hbrhbr Bill-hbrhbr commented Apr 1, 2025

Description

The CMake 3.27 release issues a deprecation warning against projects using CMake versions before 3.5, and CMake 4.0 release turns this into an error. This would create issues when using the newer machines to compile CLP.

Same issues occur with Antlr4, which is a 3rdparty lib. It is already being addressed here: antlr/antlr4#4808

For yaml-cpp, the issue is addressed here: jbeder/yaml-cpp#1351

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

  • Existing workflow passes.

Summary by CodeRabbit

  • Chores

    • Updated the YAML-CPP dependency to a newer commit, ensuring improved tracking and precision.
  • Documentation

    • Revised developer guides to reflect the updated dependency reference.

@Bill-hbrhbr Bill-hbrhbr requested a review from a team as a code owner April 1, 2025 13:14
Copy link
Contributor

coderabbitai bot commented Apr 1, 2025

Walkthrough

This pull request updates the reference to the yaml-cpp dependency across multiple project areas. The commit identifier for the yaml-cpp submodule has been changed, and corresponding dependency variables in the tasks file have been updated to reflect this new commit. Additionally, the documentation has been revised to show the new dependency reference instead of a version tag.

Changes

File(s) Change Summary
components/core/submodules/yaml-cpp and deps-tasks.yml Updated the yaml-cpp reference from commit 0579ae3d976091d7d664aa9d2527e0d0cff25763 to c2680200486572baf8221ba052ef50b58ecd816e; modified SRC_NAME and SRC_URL variables accordingly.
docs/src/dev-guide/components-core/index.md Changed the dependency version display from (v0.7.0) to (c268020) to reflect the updated commit reference.

Possibly related PRs

Suggested reviewers

  • davidlion
  • kirkrodrigues

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
deps-tasks.yml (1)

432-433: YAML-CPP Version Bump Verification

The updated dependency details for yaml-cpp on these lines are now using the new commit hash (c2680200486572baf8221ba052ef50b58ecd816e) and corresponding download URL. This change aligns with the PR objective to resolve the CMake deprecation issue by updating to a newer version of the library.

Please ensure that these new values remain consistent with the submodule references and any related documentation in the project.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c7d2072 and 694478f.

📒 Files selected for processing (3)
  • components/core/submodules/yaml-cpp (1 hunks)
  • deps-tasks.yml (1 hunks)
  • docs/src/dev-guide/components-core/index.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: lint-check (macos-latest)
🔇 Additional comments (2)
docs/src/dev-guide/components-core/index.md (1)

45-45: Confirm YAML-CPP version update is consistent.

The update to the dependency reference now shows the commit hash c268020, which aligns with the intended version bump to resolve the CMake deprecation error. Please ensure that all associated documentation and dependency references (e.g., in deps-tasks.yml) are updated accordingly.

components/core/submodules/yaml-cpp (1)

1-1: Submodule Commit Update Looks Correct

The updated submodule commit reference to c2680200486572baf8221ba052ef50b58ecd816e seems appropriate and in line with the PR objective of resolving the CMake deprecation error. Please ensure that all references to this commit in dependency configurations and documentation (such as in deps-tasks.yml and the dev guide) are updated accordingly, and that your test builds confirm the resolution of the deprecation issue.

@Bill-hbrhbr Bill-hbrhbr changed the title fix(cmake): Bump yaml-cpp version to resolve CMake deprecation errror. fix(cmake): Bump yaml-cpp and ANTLR4 versions to resolve CMake deprecation errror. Apr 1, 2025
@Bill-hbrhbr Bill-hbrhbr marked this pull request as draft April 2, 2025 04:53
@Bill-hbrhbr Bill-hbrhbr self-assigned this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant