-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cmake): Bump yaml-cpp
and ANTLR4
versions to resolve CMake deprecation errror.
#794
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis pull request updates the reference to the Changes
Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
deps-tasks.yml (1)
432-433
: YAML-CPP Version Bump VerificationThe updated dependency details for
yaml-cpp
on these lines are now using the new commit hash (c2680200486572baf8221ba052ef50b58ecd816e
) and corresponding download URL. This change aligns with the PR objective to resolve the CMake deprecation issue by updating to a newer version of the library.Please ensure that these new values remain consistent with the submodule references and any related documentation in the project.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
components/core/submodules/yaml-cpp
(1 hunks)deps-tasks.yml
(1 hunks)docs/src/dev-guide/components-core/index.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: lint-check (macos-latest)
🔇 Additional comments (2)
docs/src/dev-guide/components-core/index.md (1)
45-45
: Confirm YAML-CPP version update is consistent.The update to the dependency reference now shows the commit hash
c268020
, which aligns with the intended version bump to resolve the CMake deprecation error. Please ensure that all associated documentation and dependency references (e.g., indeps-tasks.yml
) are updated accordingly.components/core/submodules/yaml-cpp (1)
1-1
: Submodule Commit Update Looks CorrectThe updated submodule commit reference to
c2680200486572baf8221ba052ef50b58ecd816e
seems appropriate and in line with the PR objective of resolving the CMake deprecation error. Please ensure that all references to this commit in dependency configurations and documentation (such as indeps-tasks.yml
and the dev guide) are updated accordingly, and that your test builds confirm the resolution of the deprecation issue.
yaml-cpp
version to resolve CMake deprecation errror.yaml-cpp
and ANTLR4
versions to resolve CMake deprecation errror.
Description
The CMake 3.27 release issues a deprecation warning against projects using CMake versions before 3.5, and CMake 4.0 release turns this into an error. This would create issues when using the newer machines to compile CLP.
Same issues occur with
Antlr4
, which is a 3rdparty lib. It is already being addressed here: antlr/antlr4#4808For
yaml-cpp
, the issue is addressed here: jbeder/yaml-cpp#1351Checklist
breaking change.
Validation performed
Summary by CodeRabbit
Chores
Documentation