Adapting to ES 2.0.0

[antonha]

ES 2.0.0 is out, and I'd like to contribute to getting this plugin into that release.

I did some refactoring in the ComboAnalyzerClass, but most of the things are either changes required by Lucene 5.x or ES 2.x

[antonha]

This was needed due to ES checking for 'jar hell' when booting, even in test. Junit brings in hamcrest-core, which conflicts with the usage of hamcrest-all in the project's tests.

[antonha]

Any feedback would be very welcome. Most likely, there is some edge case that I've missed.

[adrianocrestani]

+1

[imranazad]

I tried running the following command:

plugin.bat install "file:///elasticsearch-2.0.0/plugins/elasticsearch-analysis-combo-es20.zip"

but I'm still getting an error regarding 'plugin-descriptor.properties' even though I can see it exists.

[imranazad]

I have built the plugin and I'm now getting the following error:

ERROR: C:\elasticsearch-2.0.0\plugins\elasticsearch-analysis-combo-2.0.0-SNAPSHOT.zip\plugin-descriptor.properties

[antonha]

@imranazad The plugin installation from file works fine for me on osx, running ES 2.0.0:

❯ bin/plugin install "file:///Users/anton/Desktop/es-plugin-test/elasticsearch-analysis-combo-2.0.0-SNAPSHOT.zip"
-> Installing from file:/Users/anton/Desktop/es-plugin-test/elasticsearch-analysis-combo-2.0.0-SNAPSHOT.zip...
Plugins directory [/Users/anton/Desktop/es-plugin-test/elasticsearch-2.0.0/plugins] does not exist. Creating...
Trying file:/Users/anton/Desktop/es-plugin-test/elasticsearch-analysis-combo-2.0.0-SNAPSHOT.zip ...
Downloading .DONE
Verifying file:/Users/anton/Desktop/es-plugin-test/elasticsearch-analysis-combo-2.0.0-SNAPSHOT.zip checksums if available ...
NOTE: Unable to verify checksum for downloaded plugin (unable to find .sha1 or .md5 file to verify)
Installed analysis-combo into /Users/anton/Desktop/es-plugin-test/elasticsearch-2.0.0/plugins/analysis-combo

If I guess correctly from your commands, it seems like you have placed the zip-file in the plugin directory, and then try to run the install script on that file? I don't believe that's how the plugin script is intended to be used. Could you try placing the built .zip-file somewhere else, and running the plugin script pointing to that file instead?

This could also be due to permission issues, or due to the plugin-script not working correctly on windows (but that would be highly unlikely).

Until further proof, I'm going to assume that this is not an issue with this plugin specifically.

[antonha]

@ofavre Are you still a maintainer of this repo? If so, could you leave a comment regarding this PR? If not, could you point me in the right direction?

Any help would be greatly appreciated :)

[rog]

I got the same error as @imranazad:

ERROR: Could not find plugin descriptor 'plugin-descriptor.properties' in plugin zip

I did a wget "https://github.com/antonha/elasticsearch-analysis-combo/archive/master.zip"

and then sudo bin/plugin install "file:///home/user/master.zip"

[antonha]

@RoGr This plugin is what ES calls a "Java Plugin", which means (among other things) that the zip-file to be installed needs to be built to contain .jar files with .class files in it. For this plugin, this file is built using maven.

You were trying to install a .zip archive containing the source code. This will never work. To install the plugin, you need to build the file from source (until it makes in into the main branch). Also, you should not be using the master branch of my fork. The es20 branch contains the necessary changes for ES 2.0.

[rog]

Yeah, I realised that I will built the plugin from your es20 branch and give you feedback..

Hope @yakaz or somebody merge your work to the main repo.

Thank you.

[imranazad]

@antonha Sorry for the late response, it's been manic recently. I placed the plugin in a different location and it worked! Many thanks, I really needed this plugin desperately.

[felixbarny]

@yakaz are you going to merge this? This would be really important to us.

[felixbarny]

Seems like ES 2.2 needs another adjustment

java.lang.IllegalAccessException: Class org.elasticsearch.common.inject.DefaultConstructionProxyFactory$1 can not access a member of class org.elasticsearch.index.analysis.ComboAnalyzerProvider with modifiers ""

[vicmosin]

So did you guys fix it? I am still receiving

ERROR: Could not find plugin descriptor 'plugin-descriptor.properties' in plugin zip

during installation..

P.S. I have ES v2.1.0

[felixbarny]

Have you found an alternative to this plugin which works with current Elasticsearch versions? Unfortunately, this project does not seem to be maintained anymore :( I'm stuck on older versions because of it.

[vicmosin]

@felixbarny Unfortunately no..

[paulhyo]

Has everybody found an alternative to this plugin which works with current Elasticsearch versions????

[Kijewski]

No, I'm still using the old ES version because of that. IMO this plugin is essential and should be adopted into the core. :-/

[waizuwolf]

I tried to port this plugin to ES 2.2.0 , I was able to build it. I made the request to ElasticSearch and got following error :
java.lang.NoClassDefFoundError: Could not initialize class org.apache.lucene.util.ReaderCloneFactory
I have posted all the logs @ StackOverflow
Any idea , why this is happening. It's working fine on ES 2.1.2