Implement NewType pattern for VoiceModelId to improve type safety #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a NewType pattern (similar to Rust's NewType or Scala's OpaqueType) for model IDs in the VoicevoxCoreSharp library, making the types more clear and ensuring better type safety.
Changes
VoiceModelId
record type to wrap string IDsVoiceModelFile
to useVoiceModelId
instead of raw stringsSynthesizer
methods to accept and work withVoiceModelId
Benefits
Implementation Details
Fixes #206.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
cdn.fwupd.org
/usr/bin/fwupdmgr refresh
(dns block)crl3.digicert.com
dotnet build src/VoicevoxCoreSharp.Core/VoicevoxCoreSharp.Core.csproj
(dns block)dotnet test tests/VoicevoxCoreSharp.Core.Tests/VoicevoxCoreSharp.Core.Tests.csproj --filter FullyQualifiedName~VoiceModelTest
(dns block)crl4.digicert.com
dotnet build src/VoicevoxCoreSharp.Core/VoicevoxCoreSharp.Core.csproj
(dns block)dotnet test tests/VoicevoxCoreSharp.Core.Tests/VoicevoxCoreSharp.Core.Tests.csproj --filter FullyQualifiedName~VoiceModelTest
(dns block)ocsp.digicert.com
dotnet build src/VoicevoxCoreSharp.Core/VoicevoxCoreSharp.Core.csproj
(dns block)dotnet test tests/VoicevoxCoreSharp.Core.Tests/VoicevoxCoreSharp.Core.Tests.csproj --filter FullyQualifiedName~VoiceModelTest
(dns block)s.symcb.com
dotnet build src/VoicevoxCoreSharp.Core/VoicevoxCoreSharp.Core.csproj
(dns block)dotnet test tests/VoicevoxCoreSharp.Core.Tests/VoicevoxCoreSharp.Core.Tests.csproj --filter FullyQualifiedName~VoiceModelTest
(dns block)s.symcd.com
dotnet build src/VoicevoxCoreSharp.Core/VoicevoxCoreSharp.Core.csproj
(dns block)dotnet test tests/VoicevoxCoreSharp.Core.Tests/VoicevoxCoreSharp.Core.Tests.csproj --filter FullyQualifiedName~VoiceModelTest
(dns block)ts-crl.ws.symantec.com
dotnet build src/VoicevoxCoreSharp.Core/VoicevoxCoreSharp.Core.csproj
(dns block)dotnet test tests/VoicevoxCoreSharp.Core.Tests/VoicevoxCoreSharp.Core.Tests.csproj --filter FullyQualifiedName~VoiceModelTest
(dns block)ts-ocsp.ws.symantec.com
dotnet build src/VoicevoxCoreSharp.Core/VoicevoxCoreSharp.Core.csproj
(dns block)dotnet test tests/VoicevoxCoreSharp.Core.Tests/VoicevoxCoreSharp.Core.Tests.csproj --filter FullyQualifiedName~VoiceModelTest
(dns block)www.microsoft.com
dotnet test tests/VoicevoxCoreSharp.Core.Tests/VoicevoxCoreSharp.Core.Tests.csproj --filter FullyQualifiedName~VoiceModelTest
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.