Skip to content

fix(dlx): use binary name if package name doesn't match #2728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2021

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Apr 10, 2021

What's the problem this PR addresses?

Running yarn dlx on a package where the binary name doesn't match the package name requires explicitly listing it using yarn dlx -p <package> <binary name>, but this is only necessary if the package has multiple binaries.

Closes #2013

How did you fix it?

If there is only one binary available and the binary name wasn't explicitly provided use it instead of the package name

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz requested a review from arcanis as a code owner April 10, 2021 15:35
@merceyz merceyz force-pushed the merceyz/invalid-binary-name branch from 466912c to 26a9149 Compare April 10, 2021 15:38
@arcanis arcanis merged commit 6ede39d into master Apr 10, 2021
@arcanis arcanis deleted the merceyz/invalid-binary-name branch April 10, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] dlx on packages with a single binary doesn't execute it if the name doesn't match the package
2 participants