feat(llm-bridge): supports to intercept error for responding #1036
+121
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1036 +/- ##
==========================================
- Coverage 46.23% 46.21% -0.03%
==========================================
Files 102 102
Lines 7254 7277 +23
==========================================
+ Hits 3354 3363 +9
- Misses 3700 3713 +13
- Partials 200 201 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -172,10 +171,11 @@ func NewHandler(service *Service) *Handler { | |||
| // HandleOverview is the handler for GET /overview | |||
| func (h *Handler) HandleOverview(w http.ResponseWriter, r *http.Request) { | |||
| w.Header().Set("Content-Type", "application/json") | |||
| ww := w.(EventResponseWriter) | |||
There was a problem hiding this comment.
The forced type assertion to EventResponseWriter might cause a runtime panic if 'w' does not implement this interface. Consider using a safe type assertion (e.g., 'if ww, ok := w.(EventResponseWriter); ok {...}') and handling the failure case.
Copilot uses AI. Check for mistakes.
fanweixiao
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
InterceptError(code int, err error)function forEventWriterto intercept errors and send error messages back to the client.