Allow configuration of bundle download behaviour of open-policy-agent filter #3464
+914
−177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjungsbluth
reviewed
Mar 31, 2025
mjungsbluth
reviewed
Mar 31, 2025
torwunder
force-pushed
the
override-period-plugin-triggers
branch
from
fb17e73 to
d2b81c0
Compare
mjungsbluth
reviewed
Mar 31, 2025
|
|
||
| func (opa *OpenPolicyAgentInstance) verifyAllPluginsStarted() error { | ||
| allPluginsReady := true | ||
| for pluginName, status := range opa.manager.PluginStatus() { |
There was a problem hiding this comment.
Maybe we make it explicit that we only wait for the bundle and discovery plugin?
There was a problem hiding this comment.
it is checking the status of all plugins to align with the normal startup without the control loop
mjungsbluth
reviewed
Mar 31, 2025
torwunder
force-pushed
the
override-period-plugin-triggers
branch
from
d2b81c0 to
a38dc7f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds configuration options to control the periodic triggering behavior of the Open Policy Agent filter, allowing manual override of the automatic bundle downloads and discovery triggers. Key changes include:
- Adding new configuration flags and options for override behavior, plugin trigger interval, and maximum trigger jitter.
- Updating the startup and plugin trigger logic in both production and test code.
- Introducing configuration hook changes for manual override in plugin triggers.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| skipper.go | Adds new options for enabling override of period triggers and configuring intervals/jitter. |
| filters/openpolicyagent/openpolicyagent_test.go | Updates tests to cover various scenarios for plugin trigger override and error handling. |
| filters/openpolicyagent/openpolicyagent.go | Implements manual override handling for plugin triggers and adds retry logic. |
| filters/openpolicyagent/internal/confighook.go and confighook_test.go | Introduces a manual override hook for discovery and bundle plugin configurations. |
| config/config.go and config/config_test.go | Updates configuration schema and tests with new flags related to plugin trigger override. |
|
@torwunder FYI, I am testing what Copilot review is capable of so I've requested a review from it. |
torwunder
force-pushed
the
override-period-plugin-triggers
branch
from
a38dc7f to
47fbff0
Compare
- control timing of f.ex. bundle download directly - fail fast for non-recoverable errors Signed-off-by: Torsten Wunderlich <[email protected]>
torwunder
force-pushed
the
override-period-plugin-triggers
branch
from
47fbff0 to
ebd3bea
Compare
config/config.go
Outdated
| OpenPolicyAgentMaxRequestBodySize int64 `yaml:"open-policy-agent-max-request-body-size"` | ||
| OpenPolicyAgentMaxMemoryBodyParsing int64 `yaml:"open-policy-agent-max-memory-body-parsing"` | ||
| EnableOpenPolicyAgent bool `yaml:"enable-open-policy-agent"` | ||
| EnableOpenPolicyAgentOverridePeriodTriggers bool `yaml:"enable-open-policy-agent-override-period-triggers"` |
There was a problem hiding this comment.
Should it have -plugin in the name?
Also please put related configs next to each other:
enable-open-policy-agent[-plugin]-override-period-triggers
open-policy-agent-plugin-trigger-interval
bce1f8a to
5aa86e1
Compare
Signed-off-by: Torsten Wunderlich <[email protected]>
torwunder
force-pushed
the
override-period-plugin-triggers
branch
from
5aa86e1 to
8be65b3
Compare
Signed-off-by: Torsten Wunderlich <[email protected]>
Signed-off-by: Torsten Wunderlich <[email protected]>
Signed-off-by: Torsten Wunderlich <[email protected]>
Signed-off-by: Torsten Wunderlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #3119
Solution
add option to override the period trigger for discovery and bundle plugins
Context
The current (and future default) behaviour is relying on the configurable startup timeout to determine if the open-policy-agent filter can successfully serve requests (if it was able to download the bundles, aso).
The solution is based on a [change](add option to override period trigger for plugin) in upstream opa that exposes the httpError struct on the trigger method.