routing: Improve first route load signaling #3473
Draft
+21
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dataclients may load routes with arbitrary delays. When multiple dataclients are used, it's possible that one dataclient loads routes multiple times while another doesn't load any routes at all. This could incorrectly signal that the first route has been loaded, even though the routing table only contains routes from a single dataclient. This change fixes route update logic to signal first load only after routes from all configured dataclients are received at least once. An alternative to zalando#3447 Signed-off-by: Aleksandr Ponimaskin <[email protected]>
| @@ -96,6 +97,7 @@ func receiveFromClient(c DataClient, o Options, out chan<- *incomingData, quit < | |||
| continue | |||
| case initial || len(routes) > 0 || len(deletedIDs) > 0: | |||
| var incoming *incomingData | |||
| once.Do(firstLoad.Done) | |||
There was a problem hiding this comment.
I think there is a race condition - this will signal first load before actual table is updated (which happens around r.routeTable.Store(rt) )
You can play/test this by adding time.Sleep here.
There was a problem hiding this comment.
Yup, tests are failing exactly because of this race.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dataclients may load routes with arbitrary delays. When multiple dataclients are used, it's possible that one dataclient loads routes multiple times while another doesn't load any routes at all. This could incorrectly signal that the first route has been loaded, even though the routing table only contains routes from a single dataclient.
This change fixes route update logic to signal first load only after routes from all configured dataclients are received at least once.
An alternative to #3447