Update postgres_backup.sh to cleanup daily backups #1094
+1
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes safeguard to leave at least as many backups as BACKUP_NUM_TO_RETAIN
Currently when running backups on a schedule any less frequent then daily the backups are not cleaned up as the zalando/postgres-operator documentation suggests. See ticket #425.
This PR fixes #425.
The safeguard was not mentioned in the documentation.
Also: BACKUP_NUM_TO_RETAIN is a number of days i would suggest renaming it to BACKUP_NUM_DAYS_TO_RETAIN
it is only used in the zalando/postgres-operator docs. Let me know if that fix is desired. Decided to keep the fix small for now.
Multiple solutions already offered, this would be the most simple one. Also see possible fix in #425.