Skip to content

linux: more appdata-related changes #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2024
Merged

Conversation

guihkx
Copy link
Contributor

@guihkx guihkx commented Feb 21, 2024

These changes are mostly relevant for Flathub, as they've recently transitioned to a more modern AppStream metadata validation tool, and this PR aims to abide to these new validation rules.

Fixes a validation error given by appstreamcli:

$ appstreamcli validate org.zealdocs.zeal.appdata.xml
E: org.zealdocs.zeal:~: desktop-app-launchable-missing

https://www.freedesktop.org/software/appstream/docs/chap-Validation.html#asv-desktop-app-launchable-missing
@guihkx guihkx requested a review from trollixx as a code owner February 21, 2024 19:01
@guihkx guihkx force-pushed the linux-appdata-fixes branch from d280afa to cef93c9 Compare February 21, 2024 19:13
Gets rid of an "information" message given by appstreamcli:

$ appstreamcli validate org.zealdocs.zeal.appdata.xml
I: org.zealdocs.Zeal:7: developer-name-tag-deprecated

https://www.freedesktop.org/software/appstream/docs/chap-Validation.html#asv-developer-name-tag-deprecated
We were previously using appstream-util (from appstream-glib), which is
essentially deprecated now:

https://github.com/hughsie/appstream-glib (first line in their README)
@guihkx guihkx force-pushed the linux-appdata-fixes branch from cef93c9 to 9529aa9 Compare February 25, 2024 04:13
@trollixx trollixx merged commit de213a7 into zealdocs:main Feb 25, 2024
@guihkx guihkx deleted the linux-appdata-fixes branch March 24, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants