Skip to content

dts: xilinx: add cadence spi controllers to zynqmp.dtsi #90960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

singular0770
Copy link

Adds spi controller nodes for Cadence SPI controllers in zynqmp.dtsi. A driver for the Cadence SPI peripheral on AMD devices was recently merged into Zephyr, this PR adds support for those peripherals on ZynqMP devices. The driver was confirmed to be functional on a ZUBoard 1CG (XCZU1CG) with the fix in PR 88777 (still waiting to be merged).

Adds spi controller nodes for Cadence SPI controllers in zynqmp.dtsi.

Signed-off-by: Michael Estes <[email protected]>
Copy link

sonarqubecloud bot commented Jun 2, 2025

@henrikbrixandersen
Copy link
Member

Shouldn't this wait until #88777 was merged, then?

@singular0770
Copy link
Author

Shouldn't this wait until #88777 was merged, then?

The driver in its initial state has already been merged. Yes, software making use of this driver won't be functional until #88777 gets merged, but seeing as the driver is already available to the build system I don't particularly see why we this change needs to wait in the meantime.

@henrikbrixandersen
Copy link
Member

Shouldn't this wait until #88777 was merged, then?

The driver in its initial state has already been merged. Yes, software making use of this driver won't be functional until #88777 gets merged, but seeing as the driver is already available to the build system I don't particularly see why we this change needs to wait in the meantime.

Merging the changes in this PR without the fix in #88777 will let users enable the SPI hardware in their board DTS, but it will not be functional - correct? If so, we need to merge them in the right order.

@singular0770
Copy link
Author

Shouldn't this wait until #88777 was merged, then?

The driver in its initial state has already been merged. Yes, software making use of this driver won't be functional until #88777 gets merged, but seeing as the driver is already available to the build system I don't particularly see why we this change needs to wait in the meantime.

Merging the changes in this PR without the fix in #88777 will let users enable the SPI hardware in their board DTS, but it will not be functional - correct? If so, we need to merge them in the right order.

It will build but not run correctly. Putting this PR in draft state as I don't see a way to add dependencies on other PRs. Will take out of draft when #88777 gets merged.

@singular0770 singular0770 marked this pull request as draft June 2, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants