feat: deploy contracts using EIP1193 provider #211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EIP1193 provider was not sending the right deploy contract data to the
kernelClient.eth_sendTransaction
. This change does the following:SendTransactionParameters
do not contain the fieldto
thenencodedSafeCreateCall
function that generates code for the safe smart account to deploy a contracttx.data
to the new deploy encoded data andto
to thesafeCreateCallAddress
. It is similar to this step:sdk/packages/core/accounts/kernel/utils/account/ep0_7/encodeDeployCallData.ts
Line 9 in e942fd2
I am having some problems because
factory.deploy( ... )
computes the contract address from the sender and the nonce. This does not work in this case because the contract is being deployed by another contract. I submitted an issue to ethers.js with my current patch.