Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/sql-pool-config: Added command support for poolConfig for sql #4681

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat/sql-pool-config: Added command support for poolConfig for sql #4681

wants to merge 6 commits into from

Conversation

gnana997
Copy link

@gnana997 gnana997 commented Mar 4, 2025

#4530 : Moved SQL connection pool defaults from core to command flags

  • Removed hardcoded default values for maxIdleConns, maxOpenConns, and maxLifetime from SQL connections
  • Added these settings as command-line flags to allow user configuration
  • If not specified, falls back to default values defined in core/stores/sqlx/sqlmanager.go

@gnana997
Copy link
Author

gnana997 commented Mar 7, 2025

Hi @kevwan, could you please provide feedback on this approach when you have a moment?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gnana997