Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update:github.com/mongodb/mongo-go-driver v2.0 Migration #4687

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

me-cs
Copy link
Contributor

@me-cs me-cs commented Mar 5, 2025

github.com/mongodb/mongo-go-driver v2.0 Migration

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 96.36049% with 21 lines in your changes missing coverage. Please review.

Project coverage is 94.19%. Comparing base (8690859) to head (c4034f2).
Report is 291 commits behind head on master.

Files with missing lines Patch % Lines
core/stores/mon/v2/clientmanager.go 60.71% 11 Missing ⚠️
core/stores/mon/v2/model.go 93.10% 10 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
core/stores/mon/v2/bulkinserter.go 100.00% <100.00%> (ø)
core/stores/mon/v2/collection.go 100.00% <100.00%> (ø)
core/stores/mon/v2/options.go 100.00% <100.00%> (ø)
core/stores/mon/v2/trace.go 100.00% <100.00%> (ø)
core/stores/mon/v2/util.go 100.00% <100.00%> (ø)
core/stores/mon/v2/model.go 93.10% <93.10%> (ø)
core/stores/mon/v2/clientmanager.go 60.71% <60.71%> (ø)

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@me-cs me-cs marked this pull request as ready for review March 24, 2025 07:54
@me-cs
Copy link
Contributor Author

me-cs commented Mar 24, 2025

Hi @kevwan I have finished, go-mongodb-driver v2 version of the migration, can you please help me to review the code,thanks!

@me-cs
Copy link
Contributor Author

me-cs commented Mar 24, 2025

Since github.com/golang/mock is no longer maintained, I got an error generating functions with generic signatures, and then the official recommendation was to use go.uber.org/mock, which is still maintained, so I used it.

@me-cs
Copy link
Contributor Author

me-cs commented Mar 24, 2025

It's a bit unfortunate that go.uber.org/mock requires a minimum of go1.22, do we need to upgrade it? go is now up to go1.24.1 with the latest version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant