Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: go build path error #4713

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: go build path error #4713

wants to merge 2 commits into from

Conversation

heze666
Copy link

@heze666 heze666 commented Mar 17, 2025

No description provided.

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (8690859) to head (90bc7b7).
Report is 285 commits behind head on master.

Additional details and impacted files

see 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kevwan kevwan requested a review from Copilot March 19, 2025 15:46
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses an issue with the Go build path by changing the Dockerfile generation code.

  • Updated the Dockerfile generation to use the base name of the goFile
  • Ensured that the generated Dockerfile references the correct file for building
Comments suppressed due to low confidence (1)

tools/goctl/docker/docker.go:173

  • Ensure that using filepath.Base for goFile is correct for all build scenarios, as it may remove necessary sub-directory context if the full path is required.
GoMainFrom:  path.Join(projPath, filepath.Base(goFile)),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant