-
Notifications
You must be signed in to change notification settings - Fork 5
[Content] Load content item skeleton loaders #3460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces skeleton loaders and other loading states to various content item widgets in the content editor for a smoother user experience while data is loading. Key changes include the conditional rendering of MUI Skeleton components in place of full content views, updates to optional chaining for safer data access, and the removal of unused components.
Reviewed Changes
Copilot reviewed 28 out of 30 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
src/apps/content-editor/src/app/views/ItemEdit/Content/ActionsDrawer/ActionsDrawer.js | Entire file removed—ensure that unused references to this component have been cleared. |
src/apps/content-editor/src/app/views/ItemEdit/Content/Actions/Widgets/* | Updated multiple widget files (WidgetQuickShare, WidgetPurgeItem, WidgetPublishHistory, WidgetListed, WidgetDraftHistory, WidgetDeleteItem, Unpublish, etc.) by conditionally rendering Skeleton loaders when the item is loading. |
src/apps/content-editor/src/app/views/ItemEdit/Content/Actions/Actions.js | Updated props destructuring to safely handle an undefined item and pass isLoadingItem to child components. |
src/apps/content-editor/src/app/components/Editor/* | Added a new FieldsLoader component and modified the Editor to render it during loading. |
src/apps/active-preview/index.html | Modified the loading screen with new background color and pulsate animation instead of the previous loader. |
Files not reviewed (2)
- src/apps/content-editor/src/app/views/ItemEdit/Content/Actions/Widgets/WidgetQuickShare/WidgetQuickShare.less: Language not supported
- src/apps/content-editor/src/app/views/ItemEdit/Content/ActionsDrawer/ActionsDrawer.less: Language not supported
Comments suppressed due to low confidence (2)
src/apps/content-editor/src/app/views/ItemEdit/Content/ActionsDrawer/ActionsDrawer.js:1
- The entire file is removed. Ensure that any dependencies or references to ActionsDrawer have been updated or removed to prevent runtime errors.
-import { useState } from "react";
src/apps/active-preview/index.html:53
- [nitpick] Verify that the new pulsate animation achieves the desired visual effect without degrading performance, especially on lower-end devices.
animation: 2s ease-in-out 0.5s infinite normal none running pulsate;
src/apps/content-editor/src/app/views/ItemEdit/Content/Actions/Actions.js
Outdated
Show resolved
Hide resolved
...-editor/src/app/views/ItemEdit/Content/Actions/Widgets/ContentLinks/InstantUrl/InstantUrl.js
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Added loading skeletons when loading a content item instead of the full screen loading indicator. Resolves #3352
Content---Zesty-io---zesty-pw---Manager.webm