Skip to content

add a workaround for ziglang/zig#21905 #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

add a workaround for ziglang/zig#21905 #410

merged 1 commit into from
Mar 27, 2025

Conversation

Techatrix
Copy link
Collaborator

This workaround has been suggested and tested by @Rexicon226.

Copy link
Collaborator

@SuperAuguste SuperAuguste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@Vexu Vexu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copying files on every save doesn't seem ideal but I'll trust you on this since I don't use any of the affected OSs.

Do you think you'll have any other fixes coming up or should I make a release after this?

@Techatrix
Copy link
Collaborator Author

Copying files on every save doesn't seem ideal but I'll trust you on this since I don't use any of the affected OSs.

I was also hoping for a solution that would seem less risky but the chosen workaround is very similar to how zig fmt atomically overrides a file.

Do you think you'll have any other fixes coming up or should I make a release after this?

I published all my PRs for now. Going back into hibernation :)

@Vexu Vexu merged commit ed1d98d into master Mar 27, 2025
2 checks passed
@Techatrix Techatrix deleted the workaround-21905 branch March 27, 2025 16:45
@lordnoriyuki
Copy link

This workaround isn't working reliably for me on macOS. The only thing I've found to work reliably is the patch here on ZLS: zigtools/zls#2221 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants