Skip to content

better standard library abort() and panic() implementations for UEFI #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewrk opened this issue Dec 26, 2018 · 2 comments
Closed

better standard library abort() and panic() implementations for UEFI #1858

andrewrk opened this issue Dec 26, 2018 · 2 comments
Labels
contributor friendly This issue is limited in scope and/or knowledge of Zig internals. os-uefi standard library This issue involves writing Zig code for the standard library.
Milestone

Comments

@andrewrk
Copy link
Member

abort:

zig/std/os/index.zig

Lines 194 to 197 in 2b7e29f

Os.uefi => {
// TODO there's gotta be a better thing to do here than loop forever
while (true) {}
},

panic:

builtin.Os.uefi => {
// TODO look into using the debug info and logging helpful messages
std.os.abort();
},

@andrewrk andrewrk added contributor friendly This issue is limited in scope and/or knowledge of Zig internals. standard library This issue involves writing Zig code for the standard library. os-uefi labels Dec 26, 2018
@andrewrk andrewrk added this to the 1.0.0 milestone Dec 26, 2018
@kroepke
Copy link

kroepke commented Jan 11, 2022

I believe this has been fixed by #2944, maybe close this one?

@fifty-six
Copy link
Contributor

panic was handled in 649b872

and abort was handled in b979fc1

@Vexu Vexu closed this as completed Jul 14, 2022
@Vexu Vexu modified the milestones: 1.0.0, 0.10.0 Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor friendly This issue is limited in scope and/or knowledge of Zig internals. os-uefi standard library This issue involves writing Zig code for the standard library.
Projects
None yet
Development

No branches or pull requests

4 participants