improve uefi support #2944
improve uefi support #2944
Conversation
nrdmn
force-pushed
the
uefi
branch
2 times, most recently
from
3824822 to
1fcadee
Compare
There was a problem hiding this comment.
This looks like great work. Are you getting all these structure definitions straight from the specification? Or are you working from another implementation?
Could you link to whatever you're using for source material so that we know what to refer back to in future?
|
I'm taking the structure definitions directly from the specification. I change types only where the specification is inconsistent (e.g. the same value specified as signed and unsigned in different places) or where Zig offers more appropriate alternatives (e.g. [*]u8 instead of *u8 for strings).
|
nrdmn
force-pushed
the
uefi
branch
2 times, most recently
from
d62707d to
c3525c3
Compare
|
Most UEFI functions return the same type of error codes (same size, same semantics), see std/os/uefi/status.zig or Appendix D of the specification. I'd like to use |
| @@ -155,8 +155,7 @@ pub fn abort() noreturn { | |||
| system.abort(); | |||
| } | |||
| if (builtin.os == .uefi) { | |||
| // TODO there must be a better thing to do here than loop forever | |||
| while (true) {} | |||
| exit(0); // TODO choose appropriate exit code | |||
There was a problem hiding this comment.
Can we at least exit with non-zero status?
This PR improves support for uefi. Structure definitions taken from the specification and slightly adapted.
Before continuing work on standard library support for UEFI, I'd like to discuss this in an issue.Related discussion in #2967