Skip to content

stage2: more in-memory coercion #10201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 23, 2021
Merged

Conversation

Snektron
Copy link
Collaborator

  • In-memory coercion for function types.
  • Moved coercion of error sets from the switch in Sema.coerce to sema.coerceInMemoryAllowed. This should be OK considering all error set types are currently u16.
  • In-memory coercion for error unions.

I also moved a few tests over to stage 2 which worked, though i don't think all of them were related to these changes.

@Snektron Snektron force-pushed the stage2-more-coercion branch from b1517b1 to 59c5676 Compare November 22, 2021 03:23
@Snektron Snektron force-pushed the stage2-more-coercion branch from 59c5676 to 2b589d7 Compare November 22, 2021 03:37
@Snektron
Copy link
Collaborator Author

I don't think this this ci failure is related to my changes

@andrewrk
Copy link
Member

andrewrk commented Nov 22, 2021

I believe the CI failure is #9439

In general, I'm happy to merge stage2 PRs prior to CI checks completing if you have done the following locally:

./zig-out/bin/zig test -fLLVM ../test/behavior.zig -I ../test
./zig-out/bin/zig test -ofmt=c ../test/behavior.zig -I ../test
./zig build test-stage2 -Denable-qemu -Denable-llvm -Denable-wasmtime -Dskip-compile-errors
./zig build -Dtarget=arm-linux-musleabihf # catch int casting compile errors for 32-bit builds

Should only take a couple minutes to run all these checks.

Changes look good 👍 merging now.

@andrewrk andrewrk merged commit 11330cb into ziglang:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants