builtins: overflow arithmetic perf optimization #10854
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builtins: overflow arithmetic perf optimization
change signature of arithmetic operations @addwithOverflow,
@subWithOverflow, @mulWithOverflow, shlWithOverflow from
@operation(comptime T: type, a: T, b: T, result: *T) bool
to
@operation(comptime T: type, a: T, b: T) anytype
with anytype being a tuple
struct { res: T, ov: bool }
This removes the pointer store and load for efficiency of codegen.
Comptime operation is accordingly kept in sync.
closes #10248