Skip to content

std.os: take advantage of the freebsd's copy_file_range #12954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2022
Merged

std.os: take advantage of the freebsd's copy_file_range #12954

merged 1 commit into from
Nov 5, 2022

Conversation

alichraghi
Copy link
Contributor

Helps (or Closes) #9278

@alichraghi alichraghi force-pushed the master branch 5 times, most recently from fadc23a to 1dc8db3 Compare September 25, 2022 14:22
The-King-of-Toasters
The-King-of-Toasters suggested changes Sep 27, 2022
View reviewed changes
@alichraghi alichraghi force-pushed the master branch 3 times, most recently from efcedd1 to d7511b5 Compare September 27, 2022 14:05
The-King-of-Toasters
The-King-of-Toasters suggested changes Sep 28, 2022
View reviewed changes
@alichraghi alichraghi force-pushed the master branch 2 times, most recently from e3c1de3 to 390c462 Compare September 28, 2022 09:12
andrewrk
andrewrk requested changes Oct 18, 2022
View reviewed changes
Copy link
Member

@andrewrk andrewrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. Can you please make it only do 1 runtime switch on the return code? It's OK to duplicate some of the common switch prongs, such as .FBIG => return error.FileTooBig,.

@alichraghi alichraghi force-pushed the master branch 2 times, most recently from afbc040 to 8931d0b Compare October 18, 2022 19:37
@alichraghi
Copy link
Contributor Author

CI failure is because of #13055

@andrewrk
Copy link
Member

Should be fixed if you rebase against latest master.

@alichraghi alichraghi requested review from andrewrk and removed request for The-King-of-Toasters October 19, 2022 09:37
@andrewrk andrewrk merged commit aea617c into ziglang:master Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The-King-of-Toasters The-King-of-Toasters The-King-of-Toasters requested changes

@andrewrk andrewrk Awaiting requested review from andrewrk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alichraghi @andrewrk @The-King-of-Toasters