[WIP - #633] Offset Functions #1410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrk
added
the
work in progress
|
Let me know when this is ready for review |
raulgrell
force-pushed
the
BitByteOffsetOfs
branch
from
ddb7104 to
09a1162
Compare
|
This is done, sorry about the delay! |
andrewrk
removed
the
work in progress
winksaville
reviewed
Sep 22, 2018
| assert(@ptrToInt(&a.a) - @ptrToInt(&a) == @offsetOf(A, "a")); | ||
| assert(@ptrToInt(&a.b) - @ptrToInt(&a) == @offsetOf(@typeOf(a), "b")); | ||
| assert(@ptrToInt(&a.c) - @ptrToInt(&a) == @offsetOf(@typeOf(a), "c")); | ||
| std.debug.assert(@byteOffsetOf(P, "a") == 0 and @byteOffsetOf(S, "a") == 0); |
There was a problem hiding this comment.
I thought the compiler could reorder fields for regular structs, so it seems to me the bit and byte offset tests using S might be incorrect depending changes in the compiler or settings such as the target. The original tests using the difference of addresses seems like a better assertation.
|
You are right, the language might reorder fields and the current test is incorrect. I think ptr to int doesnt work at comptime, so either way theres a problem. The compiler isn't doing reordering yet, so I didnt worry too much for now... |
|
The previous tests were using ptrInt so I'd guess it should work on this case to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #633
I'm still looking at #1408, but I'm not sure the issue is in these functions