std.compress.xz: Avoid possible integer overflow in a few places #14521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeek502
commented
Feb 3, 2023
| @@ -217,7 +217,7 @@ pub fn Decoder(comptime ReaderType: type) type { | |||
| if (status == 1) | |||
| try self.accum.reset(self.allocator); | |||
|
|
|||
| const size = try packed_reader.readIntBig(u16) + 1; | |||
| const size = @as(u17, try packed_reader.readIntBig(u16)) + 1; | |||
There was a problem hiding this comment.
Note that this will be superseded by/conflict with #14518 (comment)
Let me know if it'd be better to defer this fix to that PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14500
Note: The test cases here could definitely be improved by constructing a valid
xzinput that would otherwise trigger the overflows. That way, the test cases would actually be testing something in all release modes.