std.windows: use posix semantics to delete files, if available #15501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matu3ba
commented
Apr 29, 2023
| Flags: ULONG, | ||
| }; | ||
|
|
||
| const FILE_DISPOSITION_DO_NOT_DELETE: ULONG = 0x00000000; |
There was a problem hiding this comment.
Should I namespace these?
matu3ba
commented
Apr 29, 2023
squeek502
reviewed
Apr 29, 2023
Justification: When a file is deleted on Windows, it may not be immediately removed from the directory. This can cause problems with future scans of that directory, which will see the partially deleted file. Under some workloads and system configurations, Windows files may appear to be deleted immediately. This is the PR with requested fixup. Thanks to @SpexGuy for the original PR.
FILE_DISPOSITION_ON_CLOSE is used to set/clear the FILE_DELETE_ON_CLOSE, but we do not use that anymore and FILE_DISPOSITION_POSIX_SEMANTICS already implies unmapping of the handle and removal fo it on close.
|
Something else to double check: does test "delete case-insensitivity on windows" {
if (builtin.os.tag != .windows) return error.SkipZigTest;
var tmp = tmpDir(.{});
defer tmp.cleanup();
var file = try tmp.dir.createFile("TEST_FILE", .{});
file.close();
try tmp.dir.deleteFile("test_file");
}(will try it out myself in a bit) EDIT: It passes, so no worries there 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justification: When a file is deleted on Windows, it may not be immediately removed from the directory. This can cause problems with future scans of that directory, which will see the partially deleted file. Under some workloads and system configurations, Windows files may appear to be deleted immediately.
This is the PR with requested fixup. Thanks to @SpexGuy for the original PR.