Skip to content

Add more Dir.makePath tests and document how .. is handled in sub_path #18453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2024
Merged

Add more Dir.makePath tests and document how .. is handled in sub_path #18453

merged 2 commits into from
Jan 7, 2024

Conversation

squeek502
Copy link
Collaborator

This PR:

@squeek502 squeek502 mentioned this pull request Jan 5, 2024
Merged
rootbeer
rootbeer approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@rootbeer rootbeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :)

@squeek502 squeek502 force-pushed the makepath-parent-components branch from 4891108 to 51946f5 Compare January 6, 2024 01:56
@andrewrk andrewrk merged commit 282ff8d into ziglang:master Jan 7, 2024
@andrewrk
Copy link
Member

andrewrk commented Jan 7, 2024

Thanks @squeek502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootbeer rootbeer rootbeer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dir.makePath handles .. in the sub_path differently per-platform
3 participants
@squeek502 @andrewrk @rootbeer