Skip to content

coff: only store PDB basename #18704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2024
Merged

coff: only store PDB basename #18704

merged 1 commit into from
Mar 15, 2024

Conversation

ypsvlq
Copy link
Contributor

@ypsvlq ypsvlq commented Jan 27, 2024

Moves towards reproducible builds on Windows and makes stack traces independent of cwd and zig-cache.
Helps #12729, but doesn't solve paths in the PDB.

@kubkon
Copy link
Member

kubkon commented Jan 29, 2024

I might be misremembering things but didn't PDB/CodeView require abs paths?

@ypsvlq
Copy link
Contributor Author

ypsvlq commented Jan 29, 2024

The information provided with /PDBALTPATH does not change the location or name of the actual .pdb file; it changes the information that the linker writes in the binary file. This enables you to provide a path that is independent of the file structure of the build computer. Two common uses for this option are to provide a network path or a file that has no path information.

MS Docs

Copy link
Member

@andrewrk andrewrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous review was invalid due to a mistake I made when reading the diff. Here's a new review instead.

@ypsvlq ypsvlq force-pushed the master branch 2 times, most recently from 5edb720 to 5326909 Compare February 7, 2024 10:21
@ypsvlq ypsvlq requested a review from andrewrk February 9, 2024 01:24
@andrewrk andrewrk merged commit 6b38758 into ziglang:master Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants