-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[std.fmt] Added parsing support for f80 #20462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good.
Can you remove this (no longer needed) check here for float round-tripping? then I will trigger the CI:
zig/lib/std/fmt/format_float.zig
Line 1524 in cb308ba
if (@bitSizeOf(T) != 80) { |
Addressed all comments @tiehuis |
Windows round trip error:
I'll have a look during the week and see if I can reproduce via wine.
|
Just noting I hit #17535 when trying to test under wine. |
I wasn't able to diagnose a fix on the windows CI failures so have added a skip for the round-trip tests for now for this target, and will add an issue noting the failure for future. I've manually rebased your commits and will merge when CI passes. |
Resolves: #19263
Test plan:
zig test lib/std/fmt/parse_float.zig
passes locally with additional f80 unit tests