Sema: return undefined on comparison of runtime value against undefined #21428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#17798 ? |
|
Potentially #10703 could also be closed by this, since it describes the following "expected" behavior for comparisons between runtime values and undefined:
... which is inconsistent with #1947, and this PR makes undefined comparisons (like other operations without side effects where at least one of the operands is undefined) work the way #1947 says they should? On the other hand, it also describes a secondary problem (i.e. logging the results of a comparison between a runtime undefined value and Let me know if I'm off base, though. |
mlugg
force-pushed
the
compare-to-undef
branch
5 times, most recently
from
0b7e674 to
a5c9221
Compare
There is one minor language change here, which is that comparisons of the form `comptime_inf < runtime_f32` have their results comptime-known. This is consistent with comparisons against comptime NaN for instance, which are always comptime known. A corresponding behavior test is added. This fixes a bug with int comparison elision which my previous commit somehow triggered. `Sema.compareIntsOnlyPossibleResult` is much cleaner now!
DivergentClouds
pushed a commit
to DivergentClouds/zig
that referenced
this pull request
Sep 24, 2024
Sema: return undefined on comparison of runtime value against undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't find a corresponding issue for this -- if anyone knows of any, note them down here and I'll close them with this PR.