std.Target: Introduce Abi.androideabi to distinguish the soft float case.
#21504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase. Abi.android on its own is not enough to know whether soft float or hard float should be used. In the C world, androideabi is typically used for the soft float case, so let's go with that. Note that Android doesn't have a hard float ABI, so no androideabihf. Closes ziglang#21488.
alexrp
commented
Sep 24, 2024
|
@Beyley can you check if this fixes the problem for your project? |
|
Can confirm this fixes my issue, thanks! |
Beyley
added a commit
to LittleBigRefresh/scetool
that referenced
this pull request
Sep 25, 2024
Until ziglang/zig#21504 is merged, this wont work, but you can compile that fork to get a zig binary with the fix included until then.
ehaas
added a commit
to ehaas/arocc
that referenced
this pull request
Oct 4, 2024
ehaas
added a commit
to Vexu/arocc
that referenced
this pull request
Oct 4, 2024
alexrp
added a commit
to alexrp/zig
that referenced
this pull request
Oct 5, 2024
For the same reason as ziglang#21504.
bernardassan
pushed a commit
to bernardassan/zig
that referenced
this pull request
Oct 8, 2024
For the same reason as ziglang#21504.
richerfu
pushed a commit
to richerfu/zig
that referenced
this pull request
Oct 28, 2024
For the same reason as ziglang#21504.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abi.androidon its own is not enough to know whether soft float or hard float should be used. In the C world,androideabiis typically used for the soft float case, so let's go with that.Note that Android doesn't have a hard float ABI for 32-bit Arm, so no
androideabihf.Closes #21488.