avoid being tricked that Build.zig is build.zig #23984
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah I made an attempt to fix that issue but gave up for now. I shared some thoughts in a comment here: #23163 (comment) |
Updates `findBuildRoot` to skip `build.zig` entries if the case doesn't match. It does this by iterating over the parent directory and verifying that an entry with the same case exists. fixes ziglang#23980
marler8997
force-pushed
the
buildRootCaseInsensitive
branch
from
43a4324 to
0220f5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
findBuildRootto skipbuild.zigentries if the case doesn't match. It does this by iterating over the parent directory and verifying that an entry with the same case exists.fixes #23980